Skip to content

fix context members to follow swift APi guidelines #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

fix context members to follow swift APi guidelines #88

merged 1 commit into from
May 27, 2020

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented May 27, 2020

motivation: nicer API

changes:

  • requestID -> requestID
  • traceId -> traceID
  • invokedFunctionArn -> invokedFunctionARN

@tomerd tomerd requested review from ktoso and fabianfett May 27, 2020 04:55
@tomerd tomerd linked an issue May 27, 2020 that may be closed by this pull request
follow naming conversions in Context object #77
Closed
@tomerd
Copy link
Contributor Author

tomerd commented May 27, 2020

closes #77

ktoso
ktoso approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tomerd
fix context members to follow swift APi guidelines
ef1f4b3 
motivation: nicer API

changes:
* requestID -> requestID
* traceId -> traceID
* invokedFunctionArn -> invokedFunctionARN
* adjust examples
@tomerd tomerd force-pushed the fix/context-naming-convention branch from 3365f30 to ef1f4b3 Compare May 27, 2020 05:01
@tomerd tomerd merged commit 8c24cff into master May 27, 2020
@tomerd tomerd deleted the fix/context-naming-convention branch May 29, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@fabianfett fabianfett fabianfett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

follow naming conversions in Context object
3 participants
@tomerd @ktoso @fabianfett